Closed teocns closed 1 week ago
Attention: Patch coverage is 40.51724%
with 69 lines
in your changes missing coverage. Please review.
Flag | Coverage Δ | |
---|---|---|
unittests | 52.85% <40.51%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files with missing lines | Coverage Δ | |
---|---|---|
agentops/host_env.py | 68.83% <100.00%> (ø) |
|
agentops/llms/instrumented_provider.py | 69.23% <100.00%> (ø) |
|
agentops/meta_client.py | 47.36% <100.00%> (ø) |
|
agentops/singleton.py | 100.00% <ø> (ø) |
|
tests/test_canary.py | 100.00% <100.00%> (ø) |
|
tests/test_events.py | 100.00% <100.00%> (ø) |
|
tests/test_pre_init.py | 100.00% <100.00%> (ø) |
|
tests/test_record_action.py | 98.80% <100.00%> (ø) |
|
tests/test_record_tool.py | 98.77% <100.00%> (ø) |
|
tests/test_session.py | 100.00% <100.00%> (ø) |
|
... and 19 more |
Ready for merge @areibman @the-praxs
for the sake of clarity and linear history this PR should not be squashed but git-merged with fast forward, so that the commit showing up on history (git blame) will be run ruff on pre-existing issues
Think we need to add pre-commit hooks in the repo and add relevant dependencies in the pyproject.toml
file under a dev
section.
@the-praxs Think we need to add pre-commit hooks in the repo and add relevant dependencies in the pyproject.toml file under a dev section.
tru, don'
Fixes #509
DISCLAIMER
Ruff's formatter is actually compatible with Black's style, so we get the best of both worlds. We can't have both or they will fight over each-other. Matter of fact, state-of-the-art repositories only go with ruff.
Usage
Install once
Run manually (will run automatically on commit)
Todo
pyproject.toml
to conform with current rules and define new standards; we can decide to ignore rules that won't pass checks for now, and fix those issues on the run or Q5