search

Agentum07 / pe

0 stars 0 forks source link

Edit command: can add duplicate entries #11

Open Agentum07 opened 3 years ago

Agentum07 commented 3 years ago

Environment

Windows 11, java version 11.0.9

Steps to reproduce

Use the standard data run command edit 2 /g BlackJack /p 2.74 /dur 10 /loc Genting Casino /date 2021-10-21 12:40

edit 1 /tag drunk

Expected Result

Error message stating entry 1 and 2 are the same

Actual Result

Entries get modified. So now I played 2 games at the same time, same location, same profit, same duration.

Screenshot 2021-11-12 171120.png

nus-pe-bot commented 3 years ago

Team's Response

We warn the user that a duplicate game entry with the same game type and date already exists, as seen in this screenshot here

image.png

The screenshot shown in the bug report also has the warning

image.png

We are aware of this issue, but decided to allow duplicate entries because it is possible that the user played games in very close succession (though unlikely). The warning should be sufficient to warn the user that their edit creates a duplicate entry.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Given that you allow users to input both hours and minutes, close succession is very unlikely.

However, because I can create a complete duplicate entry, according to the app I was in 2 places at once, playing the same game.

As for the warning:

Firstly, it is inconspicuous.

Secondly, a warning can be ignored. If the app wanted a confirmation that I want to input the same entry again, then that would have made more sense.