[WIP] projects page - Githubissues

AgileVentures / agile-ventures-website-react-front-end

React Front End for the AgileVentures site

4 stars 13 forks source link

[WIP] projects page #36

Closed mattwr18 closed 5 years ago

mattwr18 commented 5 years ago

fixes #19

todos:

refactor handlePageSelect method(it works, but it's really long)
handlePrevious and handleNext methods just set the selectedPage in state and add the active class for css logic seems like would be really similar to handlePageSelect...

far from being polished, but if you wanna have a look and give a review @tansaku @FedericoEsparza @Kachulio1... need to up the test coverage as well

FedericoEsparza commented 5 years ago

@mattwr18 Let's not put in WIP PRs, as it can obfuscate what's a priority, and distract, especially if there are many of them. I know that we encourage them in other AV projects, but other AV projects have other PMs. 😁

Call us, when you have a feature ready to review for merging. 😁 Or ask if we can review your branch, if you push it up.

For now I'll close this PR. Feel free to reopen it, when it's ready!

And I'll manually move the issue to In Progress.