AgoraIO-Community / Angular-Agora-RTC

12 stars 16 forks source link

Migration to webSDK 4.x or 3.6.9 #52

Open ishwara-bhat opened 2 years ago

ishwara-bhat commented 2 years ago

I am user of angular-agora-rtc version 0.1.0.

I recently received developer message from agora.

"Dear developers,

We've found a compatibility issue when using Agora Web SDK v3.6.6 or lower with Chrome v100 or above, which is slated for release in March 2022 (Please refer to Chrome Roadmap).

This incompatibility with Chrome v100 or above will render the service unusable. We strongly suggest that you upgrade to Agora Web SDK v4.X. You can download it here and read the migration guide here. If you can’t migrate to 4.x version, please update to version 3.6.9. You will need to run verification tests before going live."

I had integrated Angular-Agora-RTC npm and it had been working. Now from March/April, it stopped working with message that browser does not support webRTC.

Looks like the npm package has to bundle webRTC SDK 3.6.9. Please let me know if this is done and point to correct version so that my angular app starts working again.

Thanks

turivishal commented 2 years ago

Same issue here, please upgrade the npm with the latest version, customer facing the issues because the application stopped working please resolve it as soon as possible.

parindaBeyondm commented 2 years ago

I'm facing the same issue. Can you please update to relavant version so that we all can use this

parindaBeyondm commented 2 years ago

I am user of angular-agora-rtc version 0.1.0.

I recently received developer message from agora.

"Dear developers,

We've found a compatibility issue when using Agora Web SDK v3.6.6 or lower with Chrome v100 or above, which is slated for release in March 2022 (Please refer to Chrome Roadmap).

This incompatibility with Chrome v100 or above will render the service unusable. We strongly suggest that you upgrade to Agora Web SDK v4.X. You can download it here and read the migration guide here. If you can’t migrate to 4.x version, please update to version 3.6.9. You will need to run verification tests before going live."

I had integrated Angular-Agora-RTC npm and it had been working. Now from March/April, it stopped working with message that browser does not support webRTC.

Looks like the npm package has to bundle webRTC SDK 3.6.9. Please let me know if this is done and point to correct version so that my angular app starts working again.

Thanks

Hi ishwara-bhat, Did you find any solution for this.

turivishal commented 2 years ago

@parindaBeyondm, @ishwara-bhat,

For the temporary solution, I have cloned the repository and updated the versions, and uploaded a new NPM,

https://www.npmjs.com/package/angular-agora-rtc-anc

parindaBeyondm commented 2 years ago

@parindaBeyondm, @ishwara-bhat,

For the temporary solution, I have cloned the repository and updated the versions, and uploaded a new NPM,

  • Updated peerDependencies,
"@angular/common": "^6.0.0-rc.0 || ^6.0.0 || ~9.1.12 || ~11.2.14",
"@angular/core": "^6.0.0-rc.0 || ^6.0.0 || ~9.1.12 || ~11.2.14"
  • Updated dependencies,
"agora-rtc-sdk": "^3.6.10",

https://www.npmjs.com/package/angular-agora-rtc-anc

Nice! Thanks @turivishal . So we can use angular-agora-rtc-anc instead of above right?

Only1MrAnderson commented 2 years ago

Why not just open A PR?

turivishal commented 2 years ago

@parindaBeyondm right,

@Only1MrAnderson , they have not published NPM for 4 years, I emailed many times but no response at all.

Only1MrAnderson commented 2 years ago

@turivishal understood, I originally built this library while doing some contracting work for Agora but have not been asked/tasked with maintaining it. @sidsharma27 use to handle this type of stuff, he might be the person to bump to get the project maintained better. I don't have social media anymore but find it is easier to tweet at people to get feedback.

ishwara-bhat commented 2 years ago

I ended up upgrading to 4.x Agora SDK. This worked well. Migration didn't break many things. Main point to check is the npm dependencies such as Angular/Core version for your project dependencies.

https://blog.learningdollars.com/2022/03/29/how-to-build-a-video-app-using-angular-and-agora-rtc/

I did yarn audit and upgraded.