search

Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
326 stars 205 forks source link

TODO comment made irrelevant by eventual-send #37

Open erights opened 5 years ago

erights commented 5 years ago

https://github.com/Agoric/SwingSet/blob/350516d97a28e0d32c5cefe261c27a20a47a5639/src/kernel/liveSlots.js#L299

The eventual-send repository patches Promise.resolve to do exactly this.

warner commented 5 years ago

Does this mean we should remove the E.resolve that the comment references (and downstream code should use Promise.resolve instead)?

erights commented 4 years ago

The relevant prior binding is now HandledPromise.resolve since we are no longer patching Promise.resolve, and we no longer propose changing its meaning.

michaelfig commented 4 years ago

The HandledPromise.resolve static method will also be exported as E.resolve (after #110 lands).

Chris-Hibbert commented 1 year ago

Can this issue be closed? All the references look like it's no longer an issue.