search

Agoric / dapp-offer-up

Offer Up is a simple Dapp for the Agoric smart contract platform that permits users to explore items for sale in a marketplace
6 stars 5 forks source link

ci: restore `yarn test`, excluding e2e; restore node LTS #78

Closed dckc closed 2 months ago

dckc commented 5 months ago

fixes #77

dckc commented 5 months ago

(disabling auto-merge until https://github.com/Agoric/agoric-sdk/pull/9250 lands)

dckc commented 5 months ago

odd... ci checks aren't running. I don't see why not. clues, @rabi-siddique? @0xpatrickdev ?

0xpatrickdev commented 5 months ago

odd... ci checks aren't running. I don't see why not. clues, @rabi-siddique? @0xpatrickdev ?

I think we might need to do something like:

    runs-on: ubuntu-latest
    strategy:
      matrix:
        node-version: ['18.x', '20.x']
    steps:
      - name: Checkout Repo
        uses: actions/checkout@v3
      - name: Use Node.js LTS versions
        uses: actions/setup-node@v3
        with:
          node-version: ${{ matrix.node-version }}

See https://github.com/Agoric/agoric-sdk/blob/c11fecbb0105bde2631adc14e106daf19c3f1201/.github/workflow-templates/test-dapp.yml#L9-L21

amessbee commented 2 months ago

@dckc can we merge this now?

dckc commented 2 months ago

@dckc can we merge this now?

It doesn't seem to work. I see Some checks haven’t completed yet and I don't see how to get them to complete.

If what you want is the change to node versions, you could make a PR with just that commit.

frazarshad commented 2 months ago

@dckc @amessbee i think the CI checks arent passing because we've set unit as a required check for all PRs. but essentially we've replaced unit with unit (18) and unit (20) so thats why it cant pass that check. can we try updating the required checks for this repo?