Portfolio: setup and mobile version skeleton pull request

Ahsan12356 commented 2 years ago

This is a small project in which we had to make the toolbar and heading section of our portfolio website for mobile. We replicated this from Figma templates that were given.

Ahsan12356 commented 2 years ago

I have contents in my readme file!!!! Attached is my readme file. How can I get a filled readme file screenshot if there is no content? Screenshot from 2022-06-30 21-20-23

Ahsan12356 commented 2 years ago

the readme file is already. How can I add extra content in readme file? Attached is the screenshot of readme file.

On Thu, Jun 30, 2022 at 8:38 PM Daniel Maina @.***> wrote:

@.**** requested changes on this pull request.

Hi @Ahsan12356 https://github.com/Ahsan12356 ,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code. Invalid Code Review Request

You have submitted a project, that doesn't have any content in the readme file, kindly add content to your readme file using this template. https://github.com/microverseinc/readme-template/blob/master/README.md

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

— Reply to this email directly, view it on GitHub https://github.com/Ahsan12356/portfolio/pull/1#pullrequestreview-1025095901, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFNYEL6R6LEYA5R6O5GUSDTVRW5QJANCNFSM52JYWVGQ . You are receiving this because you were mentioned.Message ID: @.***>

BertrandConxy commented 2 years ago

[x] Hey @Ahsan12356. I would like to give you more information about what the previous reviewer wanted to mean. It is true that you have README which has content but it is on the main branch, not the portfolio-mobile-skeleton. You should have added after creating this branch and as a result, you don't have it here on this branch. Please watch this video and follow the advice given. As long as you have an updated README file on this branch, then it will be good to be reviewed.

Ahsan12356 commented 2 years ago

Thankyou very much for letting me know. That's really nice of you my friend. Can you suggest me a valid tutorial or video tutorial that shows the whole procedure of pulling requests and all that. Thanks in advance!

Ahsan12356 commented 2 years ago

I made all the changes emphasized by you. Now hopefully, there is no other issue.

Ahsan12356 / portfolio-nolonger

Portfolio: setup and mobile version skeleton pull request #1

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.