Adds a status page - Githubissues

Aircloak / aircloak

This repository contains the Aircloak Air frontend as well as the code for our Cloak query and anonymization platform

2 stars 0 forks source link

Adds a status page #4908

Closed sebastian closed 3 years ago

sebastian commented 3 years ago

This pull-request is a bit of a mess... I went one way, and then changed the whole idea and went in a different one. I recommend reviewing the final version rather than the individual commits...

The activity monitor has been broken up. The live view of queries is moved to the queries admin section. The activity monitor is now called status page. On this status page I additionally show some stats requested by Telefonica.

On a big screen: CleanShot 2021-06-22 at 17 44 15

On a smaller screen: CleanShot 2021-06-22 at 17 44 21

sebastian commented 3 years ago

Since you have already given the pull-request a cursory look, I'm giving you the review too, @cristianberneanu. Feel free to review.

Meanwhile I'll try to get the CI to pass by restarting it.

sebastian commented 3 years ago

You should probably test the performance of this on demo, to see what indexes might be needed.

True. Should be checked. The good thing is that:

it filters on the same attributes as the audit log already does.
time slices are relatively narrow

aircloak-robot commented 3 years ago

Standard tests have passed 💯

sebastian commented 3 years ago

Aha! I found the error I think! It's only test related...

aircloak-robot commented 3 years ago

Standard tests have passed 💯

aircloak-robot commented 3 years ago

Standard tests have passed 🎉

sebastian commented 3 years ago

Finally tests pass 😄 Feel free to re-review.

aircloak-robot commented 3 years ago

Pull request can be merged ❤️