Fixed secondary_sub_visibility=never not working

[Aquafina-water-bottle]

I attempted to use the following option in my config:

secondary_sub_visibility=never

It seems like the secondary subtitles still showed up until I used ctrl+v. This PR fixes that issue.

Notes:

• I didn't test it all too much, but I at least tested that ctrl+v still works with all three options in the config.
• I can't seem to find any uses for the self.visibility ~= 'auto' section (even in change_visibility() function), but I kept it just in case. In other words, everything seems to work perfectly fine even if the condition was removed.

[tatsumoto-ren]

I can't seem to find any uses for the self.visibility ~= 'auto' section (even in change_visibility() function), but I kept it just in case. In other words, everything seems to work perfectly fine even if the condition was removed.

"auto" means that visibility will be controlled by moving the mouse.

[Aquafina-water-bottle]

I can't seem to find any uses for the self.visibility ~= 'auto' section (even in change_visibility() function), but I kept it just in case. In other words, everything seems to work perfectly fine even if the condition was removed.

"auto" means that visibility will be controlled by moving the mouse.

What I mean is that if I changed the code:

   if self.visibility ~= 'auto' then
        mp.set_property_bool('secondary-sub-visibility', self.visibility == 'always')
    end

to the following:

    mp.set_property_bool('secondary-sub-visibility', self.visibility == 'always')

then it appears to behave exactly the same, including the hovering ability with auto. This applies for both if conditions.

[tatsumoto-ren]

I guess you're right about checking the condition on startup, but I don't like that you duplicated the code.

[Aquafina-water-bottle]

I guess you're right about checking the condition on startup, but I don't like that you duplicated the code.

Sounds good, I'll move it to a function in a second.

[tatsumoto-ren]

it appears to behave exactly the same, including the hovering ability with auto. This applies for both if conditions.

Makes sense. If it is set to auto then secondary-sub-visibility will be changed when you move the mouse, so setting it beforehand has no effect.

[Aquafina-water-bottle]

Alright, I removed the if condition and separated it into a update_visibility function. Let me know if there's any other problems!

[tatsumoto-ren]

That's okay. Thank you!