Open karip opened 12 months ago
I have not tested AIFF enough, so your report is very helpful. I agree with you that an unsupported compression type input should not cause panic. This needs to be fixed in the next version.
I didn't dare to support 8bit samples. Because in many cases IMA-ADPCM is better in terms of sound quality. If a perfect AIFF decoder is the goal, it should be supported, but I have no plans to support it in the future, because I have decided that pacmog is good enough to work for embedded applications.
Anyway, thank you for your detailed report, it is much appreciated.
It's ok if you don't want to support 8-bit samples. Does AIFF support IMA-ADPCM?
I noticed that you opened separate issues for the bugs. I opened few more issues about missing formats. Thank you for creating pacmog! It has given me some ideas how to improve my test suite.
I have written an AIFF test suite and I decided to try how pacmog can read the files in it.
Here's a summary of the results for pacmog:
Here's full test results (many fail because 8-bit samples and compressed files are not supported, so the result is actually quite ok):
For comparison, here's macOS AudioToolbox results.
You can run the test suite yourself by building the tester code and running the test suite like this (requires python3):
pacmog-rs-tester.rs
cargo install cargo-single
(or you can create a project for the tester yourself)cargo single run pacmog-rs-tester.rs