search

Akryum / meteor-vite

MIT License
33 stars 16 forks source link

fix(build): use `meteor node` command instead of `node` #22

Closed red-meadow closed 1 year ago

red-meadow commented 1 year ago

Closes #18 and this one.

This PR replaces node XXX command with meteor node XXX in vite-bundler/build.js, as described in this comment.

This is a small but very critical fix for those using meteor-base docker image. The building is not possible without it. @Akryum , please review it, it's just 2 lines.

diavrank commented 1 year ago

It worked with my Meteor + Vue app

Screenshot 2023-02-04 at 13 33 10

Everything is running well in the production environment.

Thanks soooo much for this PR.

@Akryum could you help us with this fix, please?

I also tested the build in my local machine and it still works with this change.

Notes:

red-meadow commented 1 year ago

@diavrank , did you have to do anything special to make Vite 4 work?

diavrank commented 1 year ago

@red-meadow no really, everything kept the same. This is the commit https://github.com/diavrank/theory-swe/pull/5/commits/79016e78bdd981b699162b384fdc4c5db2c86aa8

diavrank commented 1 year ago

@Akryum could you help us with this, please?