AlaskaAirlines / AuroDesignTokens

Abstract UI atomic values to support the Auro Design System.
https://auro.alaskaair.com/getting-started/developers/design-tokens
Apache License 2.0
19 stars 7 forks source link

new body height token #85

Closed jordanjones243 closed 2 years ago

jordanjones243 commented 2 years ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #84

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Add token that represents the height of all form elements before additional css (padding, margin & border) is applied.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

jordanjones243 commented 2 years ago

AC: This variable and value represent the height for the a peer dependency element. For example, for auro-select, we would assign the height of the dropdown within select to have a min/max height equal to this variable. Let me know if the naming is confusing or how I can make it more clear for users.

blackfalcon commented 2 years ago

I am wondering if we should take a different approach to this. Really, this isn't a font-size thing, so I don't feel comfortable creating this new token where it is proposed.

But looking at this, there is this issue that hasn't been addressed yet. https://github.com/AlaskaAirlines/AuroDesignTokens/issues/71#issuecomment-1227500143

If we add var(--auro-size-500) which would be 2.5rem and then the height we would use for the form elements is consistent with other sizing tokens.

This would also better refactor this update as well. https://github.com/AlaskaAirlines/auro-select/pull/98/files

@leeejune you want me to make this update?

leeejune commented 2 years ago

@blackfalcon I'm not sure what update that needs to be made, so that might be better. But I will make updates to add var(--auro-size-500) in Figma and design documentation.