AlaskaAirlines / AuroDesignTokens

Abstract UI atomic values to support the Auro Design System.
https://auro.alaskaair.com/getting-started/developers/design-tokens
Apache License 2.0
19 stars 7 forks source link

Add new token spec for size scale #86

Closed blackfalcon closed 2 years ago

blackfalcon commented 2 years ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #71

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

This feature release will add a new scale for size tokens using a X00 value scale. This update also deprecates the current scale of XL named values.

Screen Shot 2022-09-23 at 10 42 46 AM

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

leeejune commented 2 years ago

@blackfalcon are we adding all of those tokens or just changing the naming convention? Previously we did not have sizes 900 (4.5rem), 700 (3.5rem), 500 (2.5rem).

blackfalcon commented 2 years ago

Updated to include proper deprecations documentation.

Screen Shot 2022-09-26 at 1 47 48 PM
blackfalcon commented 2 years ago

@blackfalcon are we adding all of those tokens or just changing the naming convention? Previously we did not have sizes 900 (4.5rem), 700 (3.5rem), 500 (2.5rem).

Both. Using the opportunity to fix the size ladder and add the new values in the same PR.

leeejune commented 2 years ago

@blackfalcon Do we want to add all of those options? I added sizes 600 and 1000 because there was a need for it, but I'm not sure if we have reasons to add all of the other in between sizes (sizes 500, 700, 900).

blackfalcon commented 2 years ago

@blackfalcon Do we want to add all of those options? I added sizes 600 and 1000 because there was a need for it, but I'm not sure if we have reasons to add all of the others in between sizes (sizes 500, 700, 900).

I added in the 500, 700 and 900 as there are areas where that value is hard-coded into the UIs or there are some other random uses.

Is there a harm in adding them or is there something else we need to do?

leeejune commented 2 years ago

@blackfalcon Got it. No harm, but just concerned with having every spacing option for the designers in Figma. What do you think about keeping those in code only? I might need to think more about the implications of giving every single spacing option to designers.

blackfalcon commented 2 years ago

What do you think about keeping those in code only? I might need to think more about the implications of giving every single spacing option to designers.

That's your call.

leeejune commented 2 years ago

Will not add 500,700,900 in design. Ready for release in Figma.

AuroDesignSystem commented 2 years ago

:tada: This PR is included in version 3.10.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: