AlaskaAirlines / auro-hyperlink

Custom hyperlink element to connect webpages or data items to one another
https://auro.alaskaair.com/components/auro/hyperlink
Apache License 2.0
2 stars 3 forks source link

Use library scripts during build process #221

Closed jordanjones243 closed 2 months ago

jordanjones243 commented 2 months ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: # (issue, if applicable)

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Point to shared auro-library scripts for the build process, rather than local scripts

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

Summary by Sourcery

Refactor the build process to use shared auro-library scripts, enhance theming support with new styles and SCSS variables, and update documentation and tests to reflect these changes. Improve component registration for better performance and maintainability.

Enhancements:

Build:

Documentation:

Tests:

sourcery-ai[bot] commented 2 months ago

Reviewer's Guide by Sourcery

This pull request updates the auro-hyperlink component to support theming and improve accessibility. It introduces new color tokens, refactors the component's styling to use these tokens, and adds support for ondark variants. The changes also include updates to the build process, documentation, and examples.

File-Level Changes

Change Details Files
Introduced new color tokens and refactored styling to support theming
  • Added new color tokens in src/tokens.scss
  • Created src/color.scss to handle color variants
  • Updated src/style.scss to use new color tokens
  • Removed hardcoded color values from styles
src/tokens.scss
src/color.scss
src/style.scss
Added support for ondark variants
  • Created new example files with -ondark suffix
  • Updated demo/index.md and docs/partials/api.md to include ondark examples
  • Modified auro-hyperlink.js to handle ondark attribute
apiExamples/*-ondark.html
demo/index.md
docs/partials/api.md
src/auro-hyperlink.js
Improved accessibility of the component
  • Updated focus-visible styles
  • Adjusted outline and border styles for better visibility
  • Modified aria attributes and keyboard navigation handling
src/style.scss
src/auro-hyperlink.js
Updated build process and dependencies
  • Added eslint.config.mjs
  • Updated package.json with new dependencies
  • Removed old script files
  • Added src/iconVersion.js
eslint.config.mjs
package.json
src/iconVersion.js
Updated documentation and examples
  • Modified README.md to reflect new usage instructions
  • Updated CHANGELOG.md with new version information
  • Added new example files and updated existing ones
README.md
CHANGELOG.md
apiExamples/*
demo/*
docs/*

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

:white_check_mark: blackfalcon
:white_check_mark: jordanjones243
:white_check_mark: jason-capsule42
:x: semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

blackfalcon commented 2 months ago

:tada: This PR is included in version 3.7.0-beta.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: