AlaskaAirlines / auro-menu

Custom element that provides a list of options for the user to choose from
https://auro.alaskaair.com/components/auro/menu
Apache License 2.0
2 stars 3 forks source link

Jbaker/optional checkbox #136

Closed jason-capsule42 closed 2 years ago

jason-capsule42 commented 2 years ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #87

Summary:

Adds a new noCheckmark attribute. When used, selected options will not show a checkmark. Nor will padding to the left of all options be inserted to make room for checkmarks.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

blackfalcon commented 2 years ago

Was there a design specification for this update? @leeejune is this correct? The nested options seems to be in really far?

Screen Shot 2022-07-29 at 2 47 30 PM
leeejune commented 2 years ago

Screen Shot 2022-08-01 at 4 10 05 AM

This is the correct design spec.