AlaskaAirlines / auro-menu

Custom element that provides a list of options for the user to choose from
https://auro.alaskaair.com/components/auro/menu
Apache License 2.0
2 stars 3 forks source link

fix(nav): keyboard nav now skips hidden options #156 #157

Closed jason-capsule42 closed 2 years ago

jason-capsule42 commented 2 years ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #156

Summary:

hidden options were being considered as interactive which meant that the keyboard navigation by arrow keys was not skipping them.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

blackfalcon commented 2 years ago

:tada: This PR is included in version 3.9.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: