search

Alathra / AlathraExtras

A pack of random add-ons and bugfixes for AlathraMC
GNU General Public License v3.0
1 stars 1 forks source link

Feat/bait dropped on tilling or planting #122

Closed Xavbeat03 closed 2 months ago

Xavbeat03 commented 2 months ago

It's looking pretty good. It uses the dependency to ensure that the command is only run when the plugin is installed. Only concern is how the command looks in logs. Example of situation below: image

Xavbeat03 commented 2 months ago

Unfortunately, I couldn't get the CFishing API access to work properly with the Alathra version of CFishing, so this is the workaround used.

darksaid98 commented 2 months ago

The only relevant change is skipping the registration of the listener if the plugin dependency isn't loaded. (Let's be honest, there are a hundred things in this codebase that would break before your code.)

Go ahead and merge after you've had a look at the requested changes. Awesome job as always 👍