search

AlbertaSat / ex3_software

All software from flight to ground station and everything in between for the epic mission of Ex-Alta 3.
Apache License 2.0
2 stars 0 forks source link

connect the dots #63

Closed rcunrau closed 4 days ago

rcunrau commented 3 weeks ago

A few changes to CLI ground station, COMS handler, and the messaging library to get "shell ls" actually working.

DrakBoul commented 2 weeks ago

Testing on my machine I am able to successfully send ls command to shell handler! But, the groundstation panics on a parse error... I can see from the coms handler in the header message we see that the length of the message is 129 (Not 128).

TRACE got Msg { header: MsgHeader { msg_id: 0, msg_type: 0, dest_id: 7, source_id: 10, op_code: 0, msg_len: 129 }, msg_body: [97, 100, 99, 115, 95, 104, 97, 110, 100, 108, 101, 114, 10, 97, 100, 99, 115, 95, 104, 97, 110, 100, 108, 101, 114, 46, 100, 10, 98, 117, 105, 108, 100, 10, 98, 117, 108, 107, 95, 109, 115, 103, 95, 100, 105, 115, 112, 97, 116, 99, 104, 101, 114, 10, 98, 117, 108, 107, 95, 109, 115, 103, 95, 100, 105, 115, 112, 97, 116, 99, 104, 101, 114, 46, 100, 10, 99, 108, 105, 95, 103, 114, 111, 117, 110, 100, 95, 115, 116, 97, 116, 105, 111, 110, 10, 99, 108, 105, 95, 103, 114, 111, 117, 110, 100, 95, 115, 116, 97, 116, 105, 111, 110, 46, 100, 10, 99, 109, 100, 95, 100] }

rrasmuss4200 commented 2 weeks ago

Ya so shell output is correct but we can't deserialize it on the gs. I see. It just says it received from shell, but I don't notice the parsing error

rcunrau commented 1 week ago

All interesting. When I submitted the PR two weeks ago, I could run the GS on my Mac and the OBC on the Zybo, and it was able to parse the response. Currently, it won't even compile on a Mac because of I2C, and it wouldn't run anyway, because my PR doesn't know about the new UHF between the GS and OBC. Not complaining that people are not reviewing things in a timely manner, but I'm not really looking forward to starting over.

rcunrau commented 1 week ago

I think what I'm saying is that "hello world" (== "shell ls") doesn't work now, even though everything compiles. While there might have been an instant when it would have worked, that time has passed. However, there's a bunch of good stuff in this PR, and it still compiles, so if I check this in we're no worse off than we were before. So I would like to ask someone to approve this review so I can check it in (or I can force it if no one responds in a timely manner).

rcunrau commented 1 week ago

Crazy! I thought one of the big fixes I made was to remove the auto-ack from the COM/CMD handler, since I didn't see where the GS was waiting for two replies. Maybe someone else also fixed it? (I think I've resolved conflicts two or three times already, maybe that was one of them.) If you have something working I won't push this branch until I get mine going.

rrasmuss4200 commented 1 week ago

SHELL 0 ls works on main but cd still doesn't work on main. Does cd work on this branch? Still can't get it running

rcunrau commented 4 days ago

It finally works again! (between Mac and Zybo) I'm not taking any chances this time!