search

Aldriana / ShadowCraft-Engine

Calculations backend for ShadowCraft, a WoW theorycraft project.
GNU Lesser General Public License v3.0
37 stars 22 forks source link

Add gear buff for Lifeblood, Mixology and Master of Anatomy #64

Closed julienp closed 13 years ago

julienp commented 13 years ago

The base DamageCalculator init checks for mixology and master of anatomy and adds 80 agi or 80 crit rating accordingly. Mixology checks for the presence of the agi_flask buff. If we add other consumables we'll have to add similar checks and stat increases for them, since AFAIK the actual % increase from mixology depends on the consumable.

julienp commented 13 years ago

This will likely not merge cleanly with Raconzor's changes. I suggest to hold off with this pull, I'll update it once his changes are in.

julienp commented 13 years ago

This is updated now, ready to be reviewed/merged.

I changed some of the asserts from assertGreater/Less/In to assertTrue with the comparison inside the assert, as those methods are python 2.7 only.

Aldriana commented 13 years ago

Pulled, but we should find a way to add Flask of Enhancement at some point. It's not quite as easy as it might initially seem because by itself the buffs class doesn't have enough information to figure out which stat you should gain.