Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
1.03k stars 115 forks source link

The output seems to be a little green #22

Closed hooke007 closed 3 years ago

hooke007 commented 3 years ago

After testing enough videos, I found the strange output of MPCVR. The output shows a little green. And it is easy to be perceived if the the background of the picture is pure or light. Compared with other video-renderers, I think it shows the incorrect output. Another important problem is that, d3d11 seems to be more unstable (it creates many bandings)

be d9 be d11 madvr mpv

Aleksoid1978 commented 3 years ago

Upload sample video - i compare. Show Options.

v0lt commented 3 years ago

You say that there is more green, but your frame is green in all pictures. There may be a slight difference in brightness or saturation.

hooke007 commented 3 years ago

You say that there is more green, but your frame is green in all pictures. There may be a slight difference in brightness or saturation.

I do not change the brightness or saturation, do you mean mpcvr did the extra process?

Upload sample video - i compare. Show Options.

sample1-seg1 (1).zip Snipaste_2021-01-03_13-43-03

hooke007 commented 3 years ago

I tested the white (255,255,255), and I found it often outputted the (253,254,253) (maybe lower) Other vrs are correct. screenshots.zip sample2-B&W.zip

v0lt commented 3 years ago

I see a problem (+1 to green, rarely +2) only for 10-bit video and shader VP. I don’t understand how you look at it. Try version 0.5.1.1600_git2021.01.03-6622539 anyway.

hooke007 commented 3 years ago

I see a problem (+1 to green, rarely +2) only for 10-bit video and shader VP. I don’t understand how you look at it. Try version [0.5.1.1600_git2021.01.03-6622539]

Tested again with the latest version of mpcvr by sample2-B&W.zip on another PC, I saw the same problem as before.

v0lt commented 3 years ago

Test build - mpcvr-1600_fixUV_1.zip No, though. It turned out even greener.

hooke007 commented 3 years ago

Maybe worse. White(252,255,252) Black(0,1,0) Snipaste_2021-01-06_17-16-35.zip

Aleksoid1978 commented 3 years ago

Test build MPCVideoRenderer-0.5.1.1605_git2021.01.11-b51f251.zip

hooke007 commented 3 years ago

Perfect, it seems also solve the another problem (banding).

v0lt commented 3 years ago

MPCVideoRenderer-0.5.1.1606_git2021.01.13-3735f30 Please check.

hooke007 commented 3 years ago

It works well too.

v0lt commented 3 years ago

Thank you.