Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
1.03k stars 115 forks source link

is there anyway can change lighting setting? #27

Closed 4h4h270 closed 3 years ago

4h4h270 commented 3 years ago

here's the statistics https://i.imgur.com/aytGVGd.png

lighting is always dim* can't find anywhere to change it, makes picture too dark.

Aleksoid1978 commented 3 years ago

Lighting - this is just information about data from the video stream, do not pay attention. You try view HDR on SDR monitor, HDR -> SDR conversion in simple. Better view standard SDR video.

clsid2 commented 3 years ago

Edit: I see in the code that SRC_LUMINANCE_PEAK = 10000 nits Maybe using metadata value from video there would give better quality and brightness? Edit2: hmmm, lowering that value make it darker

Edit3: I played a little with DISPLAY_LUMINANCE_PEAK value Video with "Mastering display luminance"=1000 Using 75 nits instead of 125 makes it look much better. Similar in brightness to 125 nits in madVR. Screenshots: https://www.sendspace.com/file/v5shwk (not exact same frames, but brightness difference is obvious)

Aleksoid1978 commented 3 years ago

Not planned add some likes features.

Aleksoid1978 commented 3 years ago

But - patch are welcome:)

v0lt commented 3 years ago

View -> Options -> Color correction -> Brightness.

clsid2 commented 3 years ago

Normal brightness option is not a good solution for this problem.

A simple short term solution would be to add a dropdown menu where you can choose value for DISPLAY_LUMINANCE_PEAK. The "best" value depends a lot on the screen that is used. For example a projector can have pretty low peak nits (50). A normal monitor can handle the 125 that is current default, but many people will not have set monitor to highest brightness, because that is not comfortable for normal usage.

Aleksoid1978 commented 3 years ago

Patch are welcome.

v0lt commented 3 years ago

Normal brightness option is not a good solution for this problem.

I tried increasing the brightness by 25% and got a good result. Try it yourself.

4h4h270 commented 3 years ago

Normal brightness option is not a good solution for this problem.

I tried increasing the brightness by 25% and got a good result. Try it yourself.

great, tried it works good