Aleksoid1978 / VideoRenderer

Внешний видео-рендерер
GNU General Public License v3.0
1.03k stars 115 forks source link

HDR 0.5.5.1766 problem when windows HDR is already ON #35

Closed vdrfan closed 2 years ago

vdrfan commented 2 years ago

with disabled "Auto Display HDR On/Off" and enabled HDR in Windows, HDR is wahshed out. in Stat there are no nits displayed. HDR processing: Passthroug

version 0.5.5.4.1723 has no problem with that setup.

Aleksoid1978 commented 2 years ago

I check - all is ok. If no "nits" displayed - possible bad file without HDR metadata.

vdrfan commented 2 years ago

Hi, same file, with version 0.5.5.4.1723 is ok.

Test Setup: Windows 10 HDR on.

Reg settings: "UseD3D11"=dword:00000001 "ShowStatistics"=dword:00000000 "ResizeStatistics"=dword:00000001 "TextureFormat"=dword:00000000 "VPEnableNV12"=dword:00000001 "VPEnableP01x"=dword:00000001 "VPEnableYUY2"=dword:00000001 "VPEnableOther"=dword:00000001 "DoubleFramerateDeinterlace"=dword:00000001 "VPScaling"=dword:00000001 "ChromaUpsampling"=dword:00000001 "Upscaling"=dword:00000002 "Downscaling"=dword:00000002 "InterpolateAt50pct"=dword:00000001 "Dither"=dword:00000001 "SwapEffect"=dword:00000000 "ExclusiveFullscreen"=dword:00000000 "VBlankBeforePresent"=dword:00000000 "HdrPassthrough"=dword:00000001 "HdrToggleDisplay"=dword:00000000 "ConvertToSdr"=dword:00000001

Start HDR File, and you will see that Video ist not OK.

Von: Aleksoid1978 @.> Gesendet: Dienstag, 19. Oktober 2021 01:28 An: Aleksoid1978/VideoRenderer @.> Cc: onur sentürk @.>; Author @.> Betreff: Re: [Aleksoid1978/VideoRenderer] HDR 0.5.5.1766 problem when windows HDR is already ON (Issue #35)

I check - all is ok. If no "nits" displayed - possible bad file without HDR metadata.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Aleksoid1978/VideoRenderer/issues/35#issuecomment-946245409, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADE4Q3J44EVVCDSCKRMOIWDUHSUQLANCNFSM5GG7ZW5A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Aleksoid1978 commented 2 years ago

What player use ? Show screen of settings and screen with statistics(Enable in MPC VR) from main screen of video player when play.

vdrfan commented 2 years ago

i have made windows screen shots. NOT OK: 0.5.5.1766 NOT OK

OK: 0.5.4 OK

Aleksoid1978 commented 2 years ago

I don't know, need more test. About playback - better to use D3D11 decoder in MPC-BE.

P.S. Try reset settings and set again.

vdrfan commented 2 years ago

i found that it happens with LAV Video Decoder, internal MPC-BE Decoder has no problem.

Setup to reproduce: in MPC-BE - prefer external filter LAV Video Decoder (dxva2 ot d3d11)

set "HdrToggleDisplay"=dword:00000000 set windows hdr to active start the hdr video

vdrfan commented 2 years ago

dear Aleksoid1978, i am very happy with your renderer. i will Donate some money for your work (in a few days). independend of this fix/bug ...

Aleksoid1978 commented 2 years ago

Fixed.

vdrfan commented 2 years ago

thanks, its working.