search

AleoNet / snarkVM

A Virtual Machine for Zero-Knowledge Executions
https://snarkvm.org
Apache License 2.0
1.08k stars 1.5k forks source link

Introduce large execution transaction test helper #2438

Closed niklaslong closed 7 months ago

niklaslong commented 7 months ago

Builds on #2437, only the last commit is new. Introduces a test helper for a large execution transaction to it can be used in the snarkOS codec tests.

Todo: check if worth deduplicating with synthesizer/src/vm/mod.rs tests. Done.

d0cd commented 7 months ago

Should this target #2437?

d0cd commented 7 months ago

One way we can dedup is by adding a helper in ledger-test-helpers that returns a Program object with the large transition. ledger-test-helpers is already imported by synthesizer as a dev dependency.

niklaslong commented 7 months ago

Should this target https://github.com/AleoHQ/snarkVM/pull/2437?

It can, I wanted to avoid adding overhead to your changeset by pointing it that way but happy to do what is most convenient for you.

niklaslong commented 7 months ago

I've done a little deduping, I'm not super familiar with this code so lmk if I missed something or named something poorly 🙏

d0cd commented 7 months ago

Deduping looks good! Happy to merge this in to #2437 to consolidate the final review.

niklaslong commented 7 months ago

Rebased after the latest merges into mainnet-staging, should be ready to go.