AlertaDengue / AlertaDengueCaptura

Rotinas para captura de dados
GNU General Public License v3.0
6 stars 11 forks source link

Dockerize downloader_app #63

Closed esloch closed 4 years ago

esloch commented 4 years ago
esloch commented 4 years ago

Follow-up, issue #60 :

xmnlab commented 4 years ago

it seems you will need to fix some tests https://github.com/AlertaDengue/AlertaDengueCaptura/pull/63/checks?check_run_id=1179198658#step:9:58

fccoelho commented 4 years ago

I commented on top of @xmnlab comments, so I may have missed some of the places where you use shapefiles. Please replace all shapefiles by the geojsons loaded from the database.

esloch commented 4 years ago

Thanks @fccoelho :) It is a good idea to use geojson from the database, we have the dbdemo in the CI of AD for tests that we can reuse here, but it would also be another PR... The code of the current PR reads only a single shapefile from (RJ), located at tests/data, this should be pointed by an environment variable, and for production/staging, it should point to a local folder. The functionality of reading more than one shapefile will be implemented in a follow-up PR (related to issue #60 ), that aims to reuse the shapefiles already stored locally (for tests it would be located at /test/data). if we want or need, we can also recreate the functionality (from AlertaDengue) to convert geojsons to shapefile.

fccoelho commented 4 years ago

Ok about keeping this one "shapefile" for testing. But consider converting it to the geopackage format which is a single file format. Geopandas can read and save both.