search

AlexGilleran / jsx-control-statements

Neater If and For for React JSX
https://www.npmjs.com/package/babel-plugin-jsx-control-statements
MIT License
1.62k stars 64 forks source link

Added better Typescript support #88

Closed tomitrescak closed 4 years ago

tomitrescak commented 4 years ago

Hi, this pull request adds the same level of typescript support as tsx-control-statements. Sorry for the READMe.md, looks like my VSCODe reformatted it to its own format, if you wish I can undo those changes and try with the original format.

tomitrescak commented 4 years ago

Hmmm, that makes sense. Yes, I guess you do not need to transform For, I did not even think of that.

Let me know if you still want to merge and if yes, I can fix linting errors.

AlexGilleran commented 4 years ago

Yeah I'm still happy to merge - to be honest all of jsx-control-statements would probably be better done with render props, so I don't think it's unreasonable to have it in here, was just curious :).

tomitrescak commented 4 years ago

Hi, I've been busy .. what can I do for you to merge this? We are finally deploying the project and need this published for CI/CD purposes.

AlexGilleran commented 4 years ago

Just needs the lint problems that are breaking travis resolved :)

tomitrescak commented 4 years ago

Ok, should be fixed now. Thanks!

tomitrescak commented 4 years ago

@AlexGilleran do you plan to release this? I just need to know if I should update my package.jsons to install from github

AlexGilleran commented 4 years ago

Working on it :). I'm trying to upgrade all the deps, which is causing some test failures, but I'm nearly through them.

On Thu, 26 Mar 2020 at 11:25, Tomas Trescak notifications@github.com wrote:

@AlexGilleran https://github.com/AlexGilleran do you plan to release this? I just need to know if I should update my package.jsons to install from github

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AlexGilleran/jsx-control-statements/pull/88#issuecomment-604158522, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG33S6N6AAYGRJAIHEK4SDRJKOF3ANCNFSM4KCZMAVQ .

AlexGilleran commented 4 years ago

All done, you can give it a try as 4.1.0!

On Thu, 26 Mar 2020 at 11:29, Alex Gilleran alex@alexgilleran.com wrote:

Working on it :). I'm trying to upgrade all the deps, which is causing some test failures, but I'm nearly through them.

On Thu, 26 Mar 2020 at 11:25, Tomas Trescak notifications@github.com wrote:

@AlexGilleran https://github.com/AlexGilleran do you plan to release this? I just need to know if I should update my package.jsons to install from github

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AlexGilleran/jsx-control-statements/pull/88#issuecomment-604158522, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG33S6N6AAYGRJAIHEK4SDRJKOF3ANCNFSM4KCZMAVQ .

tomitrescak commented 4 years ago

Awesome! Thanks