search

AlexanderK88 / a4-uppgift-2-biograf-sajt

Arbetsmetodik och agila projektmetoder Uppgift 2 - en biograf-sajt
3 stars 1 forks source link

About us sponsors #60

Closed AnnaLenaO closed 10 months ago

AnnaLenaO commented 10 months ago

With example logo & example js for link to a sponsor.

EmilioSanchezLernia commented 10 months ago

Might I suggest making the border radius like this on line 24 of ourSponsors.scss. "border-radius: 15px 15px 0 0;" So that it looks like this?

image
AnnaLenaO commented 10 months ago

Might I suggest making the border radius like this on line 24 of ourSponsors.scss. "border-radius: 15px 15px 0 0;" So that it looks like this? image

Thank you for your suggestion. According to the wireframe in figma all four corners are rounded. Therefore the border-raidus is 15Px. Here is an image from figma to show what I mean:

image
EmilioSanchezLernia commented 10 months ago

Fair enough I can respect it in that case 👍

AnnaLenaO commented 10 months ago

Thank you both for your comments on this PR.