AlexandrNikulin / AnimationNavigationPage

AnimationNavigationPage is a NavigationPage with custom transitions animation effects.
Apache License 2.0
238 stars 37 forks source link

Getting again TypeLoadException #42

Closed felipecds closed 6 years ago

felipecds commented 6 years ago

I update the Xamarin Forms version to the latest package in nuget, and the exception reported in #39 occurred again.

If it's not possible to you update the version, how can I help?

LeoJHarris commented 6 years ago

@felipecds it is possible but its a pretty straight forward solution. Do a fork, update Xamarin.Forms package on solution and then if no issues present PR. I'm assuming if the same issue as https://github.com/AlexandrNikulin/AnimationNavigationPage/issues/39 then we just need to update the XF package.

AlexandrNikulin commented 6 years ago

@LeoJHarris @felipecds Yep, this is the same issue with Xamarin.Forms. You should use XamarinForms ver 3.0 in your solution or update Xamarin.Forms package to 3.1 for AnimationNavigationPage solution and create pull-request. If you can help with it - please do.

AlexandrNikulin commented 6 years ago

@LeoJHarris @felipecds I agree with Leo. Leo, thank you a lot! If you can update XF package again - please do.

felipecds commented 6 years ago

Submitted #43 for revision

AlexandrNikulin commented 6 years ago

@felipecds I will test it today and merge if everything is OK. Can you build nuget package with this update ?

felipecds commented 6 years ago

I’ve never done yet, but I can try.

From: Alexandr Nikulin notifications@github.com Sent: segunda-feira, 1 de outubro de 2018 10:19 To: AlexandrNikulin/AnimationNavigationPage AnimationNavigationPage@noreply.github.com Cc: Felipe Pedroti Raymundo felipe@cds-software.com.br; Mention mention@noreply.github.com Subject: Re: [AlexandrNikulin/AnimationNavigationPage] Getting again TypeLoadException (#42)

@felipecdshttps://github.com/felipecds I will test it today and merge if everything is OK. Can you build nuget package with this update ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/AlexandrNikulin/AnimationNavigationPage/issues/42#issuecomment-425904153, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFZUlvajFDYG7rydfQeYwV7Zic6IXRauks5ughYwgaJpZM4W8kTp.

LeoJHarris commented 6 years ago

@felipecds to generate the nuget package, bump the nuspec file version up. Then do a release build of the Lib. Open up a Command Prompt. Change directory to the directory containing the nuspec file which also has the nuget.exe file then type the command "nuget pack animationnavigationpage.nuspec" this will generate the nuget package.

See: https://docs.microsoft.com/en-us/nuget/create-packages/creating-a-package#creating-the-nuspec-file

felipecds commented 6 years ago

@LeoJHarris Package added!

AlexandrNikulin commented 6 years ago

@felipecds Where ? Please send me this package. I will test it and update on nuget

felipecds commented 6 years ago

I added it to my commit, but forgot to attach it here XForms.Plugin.AnimationNavigationPage.1.0.5.nupkg.zip

AlexandrNikulin commented 6 years ago

Great! I will check it and update nuget package

AlexandrNikulin commented 6 years ago

I updated Xamarin.Forms to 3.2 and upload new ver for nuget package. @felipecds @LeoJHarris thank you and sorry for delay!