search

AlexandrePTJ / kemai

Kimai desktop client
MIT License
88 stars 25 forks source link

Template button #114

Closed poelzi closed 3 months ago

poelzi commented 3 months ago

This adds a button next to the start new button but only fills in the values so you can correct them.

I was not aware of the button at all since it is flat and the icon is dark on my dark theme.

There seems to be a problem with the icon loading of the embedded icons. I was not able to track it down jet, I fixed the wrong references and added the missing cmake directive but that does not seem enough yet. Maybe it is SVG related. They are shown in qtcreator

I also don't think adding custom icons for a handful of icons is a good idea. Instead it would be better to reference the theme icons like "media-play". This way, the user can control the icons and they fit to the theme. I run a dark theme and the icons are not visible if they would load at all :)

AlexandrePTJ commented 3 months ago

@poelzi Thanks you for this PR. This is a good idea !

As I am working on a global UI/UX redesign (#98), I will obviously add this and take into account the dark/light theme feature.

About the icon, I do prefer embed icon instead of the one from Qt. I am then sure icons are consistent accross all platform.