search

AlexandreSenpai / Enma

Enma is a Python library designed to fetch and download manga and doujinshi data from many sources including Manganato and NHentai.
MIT License
80 stars 16 forks source link

Manga object returned by nhentai.py doesn't contain characters or parodies #62

Open Czevak opened 5 months ago

Czevak commented 5 months ago

The Manga object doesn't contain character or parody variables and NHentai.get() doesn't parse them either. Can these be updated to fetch them?

Macaroni-Biff commented 5 months ago

I noticed that there is an active PR that addresses this issue. The PR has failed some checks, but if you're trying to get this implemented ASAP then you may be able to work off of that PR. Just note that it is NOT from the repo creator and has failed checks so it may not work "out of the box".

AlexandreSenpai commented 5 months ago

Hello guys.

Enma isnt a NHentai specific library. Actually its an agnostic scrapper so we cant make the Manga entity with specific keys to bring all the nhentai features. At the current dev version 2.3.0.alpha-5 Enma brings in genres prop all the nhentai tags except for parodies and characters cuz it doesnt make much sense to be there as it doesnt fit with the genre purpose.

the alpha version can be installed using:

pip install -i https://test.pypi.org/simple/ enma==2.3.0a5

I want to release this version in this month, because it will bring some bug fixes and features.

Thanks for suggesting features and fixes. I love to read them, it helps to improve the lib much faster (〃￣︶￣)人(￣︶￣〃)

AlexandreSenpai commented 5 months ago

Hello! Enma version 2.3.0 has been released!

pip install enma==2.3.0
SakiSakiSakiSakiSaki commented 2 months ago

Enma brings in genres prop all the nhentai tags except for parodies and characters cuz it doesnt make much sense to be there as it doesnt fit with the genre purpose.

Will this be a planned feature at some point? Feels like a crucial bit of data missing don't you think? But I understand your stance, because as you said, this is an provider-agonistic scrapper.