Alexey-T / CudaText

Cross-platform text editor, written in Free Pascal
Mozilla Public License 2.0
2.54k stars 173 forks source link

`switch tab, to next` now works the same as `switch tab, simply to next` (regression) #5140

Closed hiiamboris closed 1 year ago

hiiamboris commented 1 year ago

This just recently worked fine in 1.194.0.0 but not in 1.195.0.5 - switch tab, to next showed a menu and defaulted to the next most recent tab used. You guys should use a tests suite or smth, as every new build brings more regressions than fixes ;)

hiiamboris commented 1 year ago

I changed the Ctrl-Tab hotkey to use switch tab, show dialog. But really this is annoying that things constantly break, makes me afraid updating it ;)

hiiamboris commented 1 year ago

What's the difference between all these tab switch modes by the way? Are there any docs? I've been always confused by so many commands working the same way. simply to next vs to next, and dialog vs what was previously to next and to previous (all worked the same).

MiroslavMatas commented 1 year ago

This just recently worked fine in 1.194.0.0 but not in 1.195.0.5 - switch tab, to next showed a menu and defaulted to the next most recent tab used. You guys should use a tests suite or smth, as every new build brings more regressions than fixes ;)

switch tab, to next + dialog - on 1.194 - it was nice… but why to show something at GUI, if I want to simply switch to next tab, directly… that dialog is/was useful, if I want to trace over list (holding Ctrl) so, change is logical to me… even if I like previous behavior…

MiroslavMatas commented 1 year ago

This just recently worked fine in 1.194.0.0 but not in 1.195.0.5 - switch tab, to next showed a menu and defaulted to the next most recent tab used. You guys should use a tests suite or smth, as every new build brings more regressions than fixes ;)

from my point of view - not regression, just missing note at history.txt : - )

hiiamboris commented 1 year ago

from my point of view - not regression, just missing note at history.txt : - )

Probably :) But if previously I didn't see the difference between switch tab, dialog, switch tab, to next and switch tab, to previous, now I don't see it between switch tab, to next/switch tab, to previous and switch tab, simply to next/switch tab, simply to previous. Complicated stuff :)

MiroslavMatas commented 1 year ago

switch tab, dialog - useful if you have open groups… on groups, without that dialog - you must to define another shortcut for focus next group

Alexey-T commented 1 year ago

thanks for report. yes I see that 'switch tab to next' now shows dialog, and i remember before it worked w/o dialog. will work on it.

Alexey-T commented 1 year ago

wait, in 1.195 we had this change

* change: default of "show_last_line_on_top" changed to False, default of "ui_tab_switcher_dialog" changed to False, default of "bracket_highlight" changed to True (thanks @z4ziggy)

so before in 1.194.0, command 'switch tab to next' did show the dialog. and now with changed default of ui_tab_switcher_dialog it does not. not bug! only changed default!

remedy: write to user.json

"ui_tab_switcher_dialog": true

Alexey-T commented 1 year ago

about our docs (ie Wiki). i may write about 'switch tab' commands to https://wiki.freepascal.org/CudaText#Tab_switcher

i see it's OK place for this text.

MiroslavMatas commented 1 year ago

wait, in 1.195 we had this change

* change: default of "show_last_line_on_top" changed to False, default of "ui_tab_switcher_dialog" changed to False, default of "bracket_highlight" changed to True (thanks @z4ziggy)

so before in 1.194.0, command 'switch tab to next' did show the dialog. and now with changed default of ui_tab_switcher_dialog it does not. not bug! only changed default!

I feel like idiot now… totally overlook this change @Alexey-T - for the future - please separate these settings/variables to more lines (one line per one setting)

Alexey-T commented 1 year ago

Miroslav, i will try (if won't forget).

@hiiamboris i added this text to mentioned wiki part:

Command Palette has several commands to switch current ui-tab:

hiiamboris commented 1 year ago

How is "reverse order" supposed to work with "visit history order"?

Alexey-T commented 1 year ago

good question. seems correct docs must be :