search

AlexsLemonade / OpenScPCA-analysis

An open, collaborative project to analyze data from the Single-cell Pediatric Cancer Atlas (ScPCA) Portal
Other
5 stars 14 forks source link

Don't have spellcheck action fail #720

Closed jashapiro closed 1 month ago

jashapiro commented 1 month ago

(Posting this after I got a workflow failure email that it took me a bit too long to figure out was not really because of something I had done.)

Since the spellcheck action already posts any spelling errors to an issue, we probably don't also need the action to fail as well. It seems like the workflow failure notice maybe goes to the last person to commit to main (did anybody else get it for the most recent failure?), which seems pretty arbitrary.

jaclyn-taroni commented 1 month ago

I would expect this to include logic that prevents failure only on the scheduled job. I think there's value to failing on relevant pull requests.

jashapiro commented 1 month ago

I would expect this to include logic that prevents failure only on the scheduled job. I think there's value to failing on relevant pull requests.

Of course you are correct. Updated to just add an exclusion of that step for scheduled jobs.