search

Alkaar / resy-booking-bot

🔫 Helps to snipe hard to get reservations at restaurants that use resy
411 stars 215 forks source link

add option of Docker-based build and execution #65

Closed NickBorgers closed 1 year ago

NickBorgers commented 2 years ago

I don't have IntelliJ and don't want to install any of the Scala tools anywhere, so I containerized this.

Alkaar commented 2 years ago

This is pretty cool. Like the initiative!

Were you intending for this to be merged down as is? There is a more scalaesque way to do this but I've honestly not had a lot of time to dig into it. But this might be "good enough" to merge it as is until I get around to figuring it out.

codecov-commenter commented 2 years ago

Codecov Report

Base: 58.62% // Head: 58.62% // No change to project coverage :thumbsup:

Coverage data is based on head (9c7bd5f) compared to base (75777f5). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #65 +/- ## ======================================= Coverage 58.62% 58.62% ======================================= Files 5 5 Lines 116 116 Branches 2 2 ======================================= Hits 68 68 Misses 48 48 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Derek+Fong). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Derek+Fong)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

NickBorgers commented 2 years ago

This is pretty cool. Like the initiative!

Were you intending for this to be merged down as is? There is a more scalaesque way to do this but I've honestly not had a lot of time to dig into it. But this might be "good enough" to merge it as is until I get around to figuring it out.

I'm good with merging it if you are.

I think you should pull it down and see if it runs for you. If there's a more scalaseque way to containerize I'm open to it, this was just a quick way to get this running without installing any tools on my box and I shared it back with you/others.

NickBorgers commented 2 years ago

This ran on my Mac, which is using Docker Desktop so a non-SELinux Linux VM.

I don't think :Z will cause any problems elsewhere.

NickBorgers commented 1 year ago

Changes were merged via force-push by @Alkaar