All-Hands-AI / OpenHands

🙌 OpenHands: Code Less, Make More
https://all-hands.dev
MIT License
37.6k stars 4.25k forks source link

[Bug]: Github Resolver comment "workflow error" when the workflow is successful #5216

Open xingyaoww opened 6 days ago

xingyaoww commented 6 days ago

Is there an existing issue for the same bug?

Describe the bug and reproduction steps

Example: https://github.com/All-Hands-AI/OpenHands/pull/5181#issuecomment-2494766867

OpenHands Installation

Other

OpenHands Version

No response

Operating System

None

Logs, Errors, Screenshots, and Additional Context

Error log:

The workflow to fix this issue encountered an error. Please check the workflow logs for more information.

github-actions[bot] commented 6 days ago

OpenHands started fixing the issue! You can monitor the progress here.

malhotra5 commented 6 days ago

I've found one issue which was introduced in this PR

target-branch parameter was added to the Attempt to resolve issue step instead of Create draft PR or push branch step in .github/workflows/openhands-resolver.yml

EDIT: target-branch paramater was introduced in the openhands-ai package which has not been released as of yet. The changes in .github/workflows/openhands-resolver.yml require the unreleased version of openhands-ai

I think there may be one more bug, will keep digging

enyst commented 4 days ago

The issue I linked looks like a duplicate of this. If you can confirm that, @malhotra5 , I'll just close it.

Example run where it clearly did everything right, just the JSON parsing says it was wrong, apparently: https://github.com/All-Hands-AI/OpenHands/pull/5242#issuecomment-2496496749