[Bug]: [Resolver] Error when parsing the JSON response on success

enyst commented 4 days ago

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Describe the bug and reproduction steps

This seems to happen all the time: (I think? I don't see a successful comment even if the agent did solve the task, please let me know if I'm doing something wrong, I'm not too familiar with the resolver ❤️ )

NOTE: the issue is that success_explanation fails parsing as JSON.

06:13:25 - openhands:ERROR: resolve_issue.py:260 - Failed to parse success_explanation as JSON: The feedback has not been successfully resolved. Looking at the thread, there are several key points:

Example: https://github.com/All-Hands-AI/OpenHands/actions/runs/11993727601/job/33434996319#step:10:696

the critique response is not present in a comment

Looking at the thread, there are several key points:...

the extra text is nowhere to be found either, I mean this text:


06:13:25 - openhands:INFO: resolve_issue.py:273 - I have updated the PR and resolved some of the issues that were cited in the pull request review. Specifically, I identified the following revision requests, and all the ones that I think I successfully resolved are checked off. All the unchecked ones I was not able to resolve, so manual intervention may be required:

[ ]: The feedback has not been successfully resolved. Looking at the thread, there are several key points:

OpenHands Installation

Other

OpenHands Version

No response

Operating System

None

Logs, Errors, Screenshots, and Additional Context

No response

enyst commented 4 days ago

This might be related to or a duplicate of https://github.com/All-Hands-AI/OpenHands/issues/5216

github-actions[bot] commented 2 days ago

OpenHands started fixing the issue! You can monitor the progress here.

github-actions[bot] commented 2 days ago

An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-5234' has been created with the attempted changes. You can view the branch here. Manual intervention may be required.

All-Hands-AI / OpenHands