All-Hands-AI / OpenHands

🙌 OpenHands: Code Less, Make More
https://all-hands.dev
MIT License
37.6k stars 4.25k forks source link

Fix issue #5015: [Bug]: Headless mode awaits for requested user feedb… #5246

Open enyst opened 4 days ago

enyst commented 4 days ago

End-user friendly description of the problem this fixes or functionality that this introduces

Explain what this PR does

When the app is running in headless mode, it must not ask the user for input. This means two things:

Read the comments in the original issue: you will find an example of how headless mode is implemented silently in external scripts.

You have a unit test for headless mode set. Read it and fix it to conform to this behavior. Then add a test for headless mode not set.


Link of any specific issues this addresses Fix #5015


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:200d70d-nikolaik   --name openhands-app-200d70d   docker.all-hands.dev/all-hands-ai/openhands:200d70d
github-actions[bot] commented 4 days ago

OpenHands started fixing the pr! You can monitor the progress here.

enyst commented 4 days ago

The PR you are fixing is: https://github.com/All-Hands-AI/OpenHands/pull/5246

Read all its contents before starting.

enyst commented 4 days ago

@openhands-agent End-user friendly description of the problem this fixes or functionality that this introduces: Headless mode must not stop to ask the user for input.

Explain what this PR does

When the app is running in headless mode, it must not ask the user for input. This means two things:

Read the comments in the original issue: you will find an example of how headless mode is implemented silently in external scripts.

github-actions[bot] commented 4 days ago

OpenHands started fixing the pr! You can monitor the progress here.

enyst commented 4 days ago

openhands-agent, the previous comments were mostly solved. We have a few more things to do now:

github-actions[bot] commented 4 days ago

OpenHands started fixing the pr! You can monitor the progress here.

enyst commented 4 days ago

@openhands-agent Python linting is failing on this PR in CI. You know how to run python linting in this project. Fix it and commit the fix.

github-actions[bot] commented 4 days ago

The workflow to fix this issue encountered an error. Please check the workflow logs for more information.

enyst commented 3 days ago

@openhands-agent Look carefully at the diff of this PR. Undo the exact changes you made to traffic control. Only those, and commit; the rest is fine.

github-actions[bot] commented 3 days ago

OpenHands started fixing the pr! You can monitor the progress here.