search

AllYarnsAreBeautiful / ayab-firmware

Contains the Arduino Firmware for the AYAB Shield
GNU General Public License v3.0
23 stars 19 forks source link

Add support for G-carriage detection #186

Closed jpcornil-git closed 7 months ago

jpcornil-git commented 7 months ago

Add support for G-carriage detection

For G-carriage, per brother doc, south-then-north transitions within 3 needles is detected (but not the other way around), when only one transition is detected (within 3 needles) then K or L is reported.

Tested on KH910 => couldn't test RHS detection due to the HW bug (and commented out L75-L81 as a consequence but it should just work as well)

dl1com commented 7 months ago

@jpcornil-git I guess it would make sense to port these changes to the 1.0 branch as well, right? Would you able to take care of this?

jpcornil-git commented 7 months ago

Is it still OK to port a change like that to 1.0 (close to release ? -> next minor release instead) ? If it is the case, I can have a look at this Cheers, jpc

dl1com commented 7 months ago

Is it still OK to port a change like that to 1.0 (close to release ? -> next minor release instead) ? If it is the case, I can have a look at this Cheers, jpc

v1.0 release will still take some time (we discussed in the dev meeting yesterday), so feel free to port it now