search

AllenInstitute / biofile-finder

An open-use web application created for easy access, collaboration, and sharing of datasets through rich metadata search, filter, sort, and direct viewing in common industry applications or in our web-based 3D Volume Viewer.
https://biofile-finder.allencell.org/
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

LOAD button on dataset page bug #306

Closed SeanLeRoy closed 4 weeks ago

SeanLeRoy commented 1 month ago

The "LOAD" button on the open-source datasets page doesn't actually load the dataset. This is because the pointer-events property here is preventing that. Resolves #300

SeanLeRoy commented 1 month ago

The only minor tradeoff from this is that the links in the "related publication" column won't be clickable in the dataset row. If we keep it that way, Lyndsay suggested that we should remove the blue link styling from that column so it doesn't look like it should be clickable (which we agreed should be fine since the link is still clickable from the side panel)

I think it still is? I'm confused about this, can you send me a video or screen share tomorrow?

aswallace commented 1 month ago

Staging/prod: link has hoverable state and opens pub in new tab

https://github.com/user-attachments/assets/c7778639-ca49-4c95-9352-bf15320fb281

without pointer events: link is blue but clicking just opens the panel

https://github.com/user-attachments/assets/962e05fe-b95a-4b27-a6ae-be64aa71c859

SeanLeRoy commented 4 weeks ago

The only minor tradeoff from this is that the links in the "related publication" column won't be clickable in the dataset row. If we keep it that way, Lyndsay suggested that we should remove the blue link styling from that column so it doesn't look like it should be clickable (which we agreed should be fine since the link is still clickable from the side panel)

Fixed in https://github.com/AllenInstitute/biofile-finder/pull/306/commits/e66d5d758df75ab0571a9fcbc448743bb0f0ca0e