AllienWorks / cryptocoins

Cryptocoins is the most complete vector/webfont icon pack of your favourite cryptocurrencies
https://allienworks.github.io/cryptocoins/icons-demo
MIT License
827 stars 195 forks source link

Offer colored SVGs #148

Open wbobeirne opened 6 years ago

wbobeirne commented 6 years ago

Hey, big fan of the project here, this is a really solid set of icons to work from. The only thing that's disappointing to me is that the svg icons aren't leveraging their ability to have multiple colors. While the icon font is great, many of these icons are more identifiable of they use their full color scheme. A great example of this is ARDR:

screen shot 2018-01-31 at 1 50 05 pm

Awwww yeaaaah

What I'd propose is revisiting each of the SVG icons, and applying their true color scheme to them. Then add a grunt process that strips the color from the SVGs so that we also generate the black ones for backwards compatibility and the icon font. This should provide the maximum amount of options without removing any existing functionality.

I've begun working on this over at https://github.com/wbobeirne/cryptocoins/tree/colors (Only through the A's at time of posting.) I'm happy to do most if not all of the work myself, but I wanted to gauge the usefulness of this, and likelihood of this getting merged in before I committed to all of the work.

AllienWorks commented 6 years ago

Thanks for the kind words!

This color issue was already proposed by many, most recently by @quoid.

The thing is that I originally made this icon pack for webfont-only (pretty much) – after all, this project is a few years old already. However I believe that even if we used colored SVGs, the webfont would be generated without problems as well (automatically stripping the color in the process). It would be wise to offer both monochromatic version as well, that's correct.

If you're up for the task, that would be more than welcome. I don't have much free time to invest in Cryptocoins recently, so the help would be appreciated. (I already thought about coloring them, but it will take some time.)

wbobeirne commented 6 years ago

Ah cool, I just caught up on his PR (#131, for posterity.) Did you two ever reach a conclusion off-thread? I'd be happy to help with whatever works best (Be it separate projects, or upstreaming his changes.)

I already made it ~25% of the way through on my branch, but it looks like the branch posted already has everything colored, so I'll probably just stop working on that.

quoid commented 6 years ago

@wbobeirne We did speak off thread about. In the end we said that it would be a better idea to do the colored versions in a different repo. You can view my branch here: https://github.com/quoid/cryptocoins/tree/quoid-proposal

Just to note, I made several suggestions about the project. Not just introducing colored version, but also normalizing all current and future icons to have consistent properties and making the icons "as close to original" as possible. There were valid reasons why @allienworks didn't want that in his project.

I got through 139 icons, if you'd like to do more and/or add to what I've done, I can send you the template I used for Sketch. Feel free to fork my fork or whatever you want. Like Martin, I'm unfortunately a bit busy now, so I am not sure when I will have time to make more contributions (could be soon, could be not-so-soon).

AllienWorks commented 6 years ago

@wbobeirne, as @quoid mentioned, we decided on two separate projects. This one (Cryptocoins) was and will continue to offer a bit stylized icons (not always originals, in terms of line widths etc.). @quoid will then (when he has time) work on his approach, featuring original logos (+ colors and more).

We decided to link both repos together, so every user/dev can choose whichever version better fits his/her purpose.

So I'd say you can decide on which version you want to work and help there. Also, that means that you don't need to throw away your changes. If they are based on these icons here, I'll gladly accept them.

wbobeirne commented 6 years ago

OK, sounds good. I'll probably finish out the color conversion on this repository (Grabbing the occasional well-colored one from @quoid if that's alright) and open a PR based on the original scope of this issue. It might be a few days though, I can only do a few icons before I get a numb sensation in brain.

andyklimczak commented 6 years ago

Sorry for the bump, just want to say I'm looking for colored svgs too!

Thank you guys

quoid commented 6 years ago

@andyklimczak I have a bunch of colored ones in my fork: https://github.com/quoid/cryptocoins/tree/quoid-proposal/svg/original

I don't when/if I will have time to add more coins to my fork...