search

AlmasB / FXGL

Java / JavaFX / Kotlin Game Library (Engine)
http://almasb.github.io/FXGL/
MIT License
4.45k stars 556 forks source link

#1331-part1 #1337

Closed DeathPhoenix22 closed 10 months ago

DeathPhoenix22 commented 10 months ago

Hi @AlmasB ,

I've completed the implementation to allow retrieving diagonal neighbours in the Grid.

Thanks,

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9504e79) 59.69% compared to head (a5039d3) 59.63%. Report is 9 commits behind head on dev.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1337 +/- ## ============================================ - Coverage 59.69% 59.63% -0.07% - Complexity 2961 2975 +14 ============================================ Files 308 310 +2 Lines 15261 15310 +49 Branches 1560 1562 +2 ============================================ + Hits 9110 9130 +20 - Misses 5628 5657 +29 Partials 523 523 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DeathPhoenix22 commented 10 months ago

@AlmasB I'm facing a codecov bug. I gently added more test coverage in my previous PR attempt and doing this PR made it loose coverage even though this PR contains 100% coverage of what I changed.

This is starting to making me loose considerable professional time and none of my other PRs were merged. I'm starting to reconsider my initiative to contribute to this engine :(

AlmasB commented 10 months ago

@AlmasB I'm facing a codecov bug. I gently added more test coverage in my previous PR attempt and doing this PR made it loose coverage even though this PR contains 100% coverage of what I changed.

You can ignore codecov for now, the PR looks fine, happy to merge, but the branch seems to be deleted.

This is starting to making me loose considerable professional time and none of my other PRs were merged. I'm starting to reconsider my initiative to contribute to this engine :(

I'm very sorry this is affecting your professional time. Please do not feel forced to spend time on these changes, as any contribution is meant to be voluntary. If you prefer, I'm happy to edit the PR and then ask for your review before merging.

DeathPhoenix22 commented 10 months ago

@AlmasB I'm facing a codecov bug. I gently added more test coverage in my previous PR attempt and doing this PR made it loose coverage even though this PR contains 100% coverage of what I changed.

You can ignore codecov for now, the PR looks fine, happy to merge, but the branch seems to be deleted.

This is starting to making me loose considerable professional time and none of my other PRs were merged. I'm starting to reconsider my initiative to contribute to this engine :(

I'm very sorry this is affecting your professional time. Please do not feel forced to spend time on these changes, as any contribution is meant to be voluntary. If you prefer, I'm happy to edit the PR and then ask for your review before merging.

I've submitted #1338 (cleaner Commit history). It contains only what's requested.