Almouro / bitrise-nvm-step

Bitrise step for installing NVM and custom NPM version
http://bitrise.io
MIT License
5 stars 7 forks source link

Failed to download step after recent 1.3.1 release #16

Closed mrister closed 2 years ago

mrister commented 2 years ago

Has the release been done fully ?

image
adamivancza commented 2 years ago

yeah I can see the same issue on our builds

adamivancza commented 2 years ago

As a workaround, you can manually downgrade your NVM step to 1.3.0 to get this working again.

ZioCain commented 2 years ago

Same here. Applied the workaround to manually set the version 1.3.0 (through bitrise.yml) and it worked.

On a side note, version 1.2.2 will also break

Almouro commented 2 years ago

Damn, seems like there are some issues on nvm https://github.com/nvm-sh/nvm/issues/1985 about exiting with code 3

I couldn't reproduce quickly and find a fix so I'll revert so that the folks on auto update don't have their CI suddenly crashing for no reason

Almouro commented 2 years ago

Here's the PR on the Bitrise step lib https://github.com/bitrise-io/bitrise-steplib/pull/3553

Sorry everyone, didn't imagine that a simple set -e would break this much. If I do re-release the set -e, I'll make it a breaking change in the versioning to be safe

mrister commented 2 years ago

Thanks @Almouro

jesse0824 commented 2 years ago

As a workaround, you can manually downgrade your NVM step to 1.3.0 to get this working again.

How would you manually downgrade NVM step to 1.3.0? I'm asking for a friend. :-)

adamivancza commented 2 years ago

As a workaround, you can manually downgrade your NVM step to 1.3.0 to get this working again.

How would you manually downgrade NVM step to 1.3.0? I'm asking for a friend. :-)

Just edit the bitrise.yml file and change the nvm step to be: - nvm@1.3.0:

ghost commented 2 years ago

version downgrade works for me

jesse0824 commented 2 years ago

@adamivancza thanks for the info! That worked for me. My builds are working again.

ronenempathy commented 2 years ago

any update on this ?

Almouro commented 2 years ago

Hi @ronenempathy, version 1.3.2 of the nvm step should revert the breaking change and work Let me know if it doesn't!