search

AlphaWallet / alpha-wallet-android

An advanced Ethereum mobile wallet
https://www.alphawallet.com
MIT License
603 stars 535 forks source link

The display area for iFrame is slightly biased to the right #502

Closed zhangzhongnan928 closed 5 years ago

zhangzhongnan928 commented 5 years ago

the below screenshots based on the same TBML for both ERC875 and ERC20 tokens.

ERC20 erc20

ERC875 erc875

TBML TBML.zip

SmartLayer commented 5 years ago

If it is an ios issue, file it in ios. If it is an Android issue, file it in Android.

SmartLayer commented 5 years ago

I reopened it because I recognised this screenshot is from Android.

SmartLayer commented 5 years ago

@farrahfazirah do you think this is an issue of android rendering or bug in the HTML code in IFRAME?

zhangzhongnan928 commented 5 years ago

@colourful-land it is from iOS

farrahfazirah commented 5 years ago

For reference, this is how the HTML looks on web browser and mobile browser respectively

screen shot 2019-01-15 at 11 50 14 am screen shot 2019-01-15 at 11 55 32 am

On iOS

I used a ruler (the red line) and pit the asset card against the iFrame to see the width difference. For better clarity, I removed the border-radius in the iFrame design for iOS:

Left side of iFrame and asset card on iOS

screen shot 2019-01-15 at 11 57 02 am

Right side of iFrame and asset card on iOS

screen shot 2019-01-15 at 11 58 16 am

As you can see, the width of the iFrame is slightly smaller than the asset card on both sides.

Suggestions for iOS

On Android

The iFrame UI on Android is not the same as iOS. It is "enclosed" with the same grey rectangular design as the asset card:

screen shot 2019-01-15 at 12 04 06 pm

I pit the asset card against the iFrame and the width of the iFrame is much smaller than the asset card on both sides:

Left side of iFrame and asset card on Android

screen shot 2019-01-15 at 12 34 19 pm

Right side of iFrame and asset card on Android

screen shot 2019-01-15 at 12 34 27 pm

Suggestions for Android