Closed lorellalou closed 1 month ago
you just need proper base instead of master
@Slach sorry yes, I closed this to open another one properly based....
i changed the base, let's wait when e2e tests complete
@lorellalou could you sync your PR with 0.24.1 to re-run tests? something like that
git remove -v
git pull upstream 0.24.1 ?
or just something like "sync upstream" in github web interface
@Slach done.
Thanks for taking the time to contribute to
clickhouse-operator
!Please, read carefully instructions on how to make a Pull Request.
This will help a lot for maintainers to adopt your Pull Request.
Important items to consider before making a Pull Request
Please check items PR complies to:
next-release
branch, not intomaster
branch1. More info--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into
master
branch, but it has to be confirmed by project's maintainer.