Altinn / altinn-design-system

Design system v2
https://designsystem.altinn.studio/
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Replace class names that collide with class names in Digdir's design system #268

Closed TomasEng closed 1 year ago

TomasEng commented 1 year ago

Description

When using components that has been copied to Digdir's design system, but not yet removed from this one, consumers might experience issues related to colliding class names. After discussing with @framitdavid, we decided to add a prefix to the class names of these components to avoid this problem.

Verification

codecov-commenter commented 1 year ago

Codecov Report

Base: 89.09% // Head: 89.09% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (506358a) compared to base (a4b568c). Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #268 +/- ## ========================================== - Coverage 89.09% 89.09% -0.01% ========================================== Files 83 83 Lines 1211 1210 -1 Branches 377 377 ========================================== - Hits 1079 1078 -1 Misses 123 123 Partials 9 9 ``` | [Impacted Files](https://codecov.io/gh/Altinn/altinn-design-system/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Altinn) | Coverage Δ | | |---|---|---| | [src/components/ErrorMessage/ErrorMessage.tsx](https://codecov.io/gh/Altinn/altinn-design-system/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Altinn#diff-c3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZS50c3g=) | `100.00% <ø> (ø)` | | | [src/components/RadioGroup/RadioGroup.tsx](https://codecov.io/gh/Altinn/altinn-design-system/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Altinn#diff-c3JjL2NvbXBvbmVudHMvUmFkaW9Hcm91cC9SYWRpb0dyb3VwLnRzeA==) | `100.00% <ø> (ø)` | | | [src/components/TextArea/TextArea.tsx](https://codecov.io/gh/Altinn/altinn-design-system/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Altinn#diff-c3JjL2NvbXBvbmVudHMvVGV4dEFyZWEvVGV4dEFyZWEudHN4) | `100.00% <ø> (ø)` | | | [src/components/Button/Button.tsx](https://codecov.io/gh/Altinn/altinn-design-system/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Altinn#diff-c3JjL2NvbXBvbmVudHMvQnV0dG9uL0J1dHRvbi50c3g=) | `94.44% <100.00%> (ø)` | | | [src/components/Checkbox/Checkbox.tsx](https://codecov.io/gh/Altinn/altinn-design-system/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Altinn#diff-c3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3gudHN4) | `85.71% <100.00%> (ø)` | | | [src/components/CheckboxGroup/CheckboxGroup.tsx](https://codecov.io/gh/Altinn/altinn-design-system/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Altinn#diff-c3JjL2NvbXBvbmVudHMvQ2hlY2tib3hHcm91cC9DaGVja2JveEdyb3VwLnRzeA==) | `100.00% <100.00%> (ø)` | | | [src/components/FieldSet/FieldSet.tsx](https://codecov.io/gh/Altinn/altinn-design-system/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Altinn#diff-c3JjL2NvbXBvbmVudHMvRmllbGRTZXQvRmllbGRTZXQudHN4) | `100.00% <100.00%> (ø)` | | | [src/components/RadioButton/RadioButton.tsx](https://codecov.io/gh/Altinn/altinn-design-system/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Altinn#diff-c3JjL2NvbXBvbmVudHMvUmFkaW9CdXR0b24vUmFkaW9CdXR0b24udHN4) | `100.00% <100.00%> (ø)` | | | [src/components/Select/MultiSelectItem.tsx](https://codecov.io/gh/Altinn/altinn-design-system/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Altinn#diff-c3JjL2NvbXBvbmVudHMvU2VsZWN0L011bHRpU2VsZWN0SXRlbS50c3g=) | `100.00% <100.00%> (ø)` | | | [src/components/Select/Select.tsx](https://codecov.io/gh/Altinn/altinn-design-system/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Altinn#diff-c3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `96.09% <100.00%> (ø)` | | | ... and [2 more](https://codecov.io/gh/Altinn/altinn-design-system/pull/268?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Altinn) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Altinn). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Altinn)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.