search

AmandaDiscord / Volcano

A light-weight LavaLink compatible replacement
MIT License
71 stars 15 forks source link

Memory Leak #6

Closed PapiOphidian closed 2 years ago

PapiOphidian commented 2 years ago

There is a current memory leak I'm investigating. I believe queues are not being properly removed or destroyed. I'll be waiting for memory usage to go high and then take a heapdump to find the issue

PapiOphidian commented 2 years ago

This is a leak within the threads

PapiOphidian commented 2 years ago

This is a leak where songs are not being destroyed entirely properly

PapiOphidian commented 2 years ago

This is an issue with Prism-media when tracks are set to have inline volume

PapiOphidian commented 2 years ago

This will have a temporary fix in the next update where infinite threads spawn instead of having a set number based on cpu core count and having theoretically infinite uptime so long as queues are being added to keep the worker alive

PapiOphidian commented 2 years ago

Partial fix in https://github.com/AmandaDiscord/Volcano/commit/dd23c79307ca44bfd27dfde76f015a135efecf58

PapiOphidian commented 2 years ago

Totally fixed in https://github.com/AmandaDiscord/Volcano/commit/5dc49a434211d7b0817ae19f9b4f78995f0348c9 Removed dep on @discordjs/opus and swapped to opusscript. Issue resolved thanks to answer from https://github.com/discordjs/voice/issues/197