AmazonAppDev / react-native-multi-tv-app-sample

πŸ“ΊπŸš€ React Native TV app sample for Android TV, Fire TV, tvOS, and web. Features customizable drawer navigation πŸ—‚οΈ, content grid πŸ–ΌοΈ, hero header πŸ¦Έβ€β™‚οΈ, and video player πŸŽ₯. Built with Expo. Perfect starter for cross-platform TV app development! 🌟
MIT No Attribution
99 stars 16 forks source link

Create a "Settings screen" #20

Open giolaq opened 1 month ago

giolaq commented 1 month ago

Is your feature request related to a problem? Please describe. It would be nice to have a "Settings screen" accessible from the Account or Profile Icon of the main screen. The "Settings" screen can contain all the configurations related to a specific account for the app. Example: Switch theme, Language configuration and so on.

Additional context Happy to discuss a design, we can be inspired by common TV apps setting screens.

giolaq commented 1 month ago

Hey @madhushree007 can I assign this to you? Put the screenshots here and let's discuss the implementation

madhushree007 commented 1 month ago

Yes, Sure. Please assign this to me. I will put screenshot here and we can take it from there.

madhushree007 commented 1 month ago

@giolaq Here is the screenshot from tvOS simulator.

Screenshot 2024-10-18 at 18 56 39 Screenshot 2024-10-18 at 18 56 53
giolaq commented 1 month ago

it's a good start thank you. I would separate "Settings" from the main routes in the drawer. We can have 2 options:

  1. Access "Settings" from the Profile. Let's say the user Select the Account name, click and open the Setting Screen.
  2. "Settings" can be at the very bottom of the left side drawer with a smaller font.

Choose one

madhushree007 commented 1 month ago

@giolaq I have separated the settings menu from the main drawer and have put it at the bottom of the left side drawer. I also created settings page in a way that more settings feature can be integrated in this page. At the moment we only have Laaguage submenu. Please have a look. Thanks

Simulator Screenshot - Apple TV - 2024-10-24 at 10 05 26 Simulator Screenshot - Apple TV - 2024-10-24 at 10 05 02 Simulator Screenshot - Apple TV - 2024-10-24 at 10 05 50

giolaq commented 4 weeks ago

This looks good! Thank you, I left some comment on the PR

madhushree007 commented 4 weeks ago

@giolaq I did not find your comments in my PR. Could you please tag me with your comment.