AmbireTech / adex-protocol-eth

Ethereum implementation of the Ambire Protocol: Ambire Wallet contracts and AdEx payment channels
https://www.ambire.com
MIT License
49 stars 24 forks source link

Identity: add delegatecall abilities #112

Closed Ivshti closed 3 years ago

Ivshti commented 4 years ago

allow the Identity contract to delegatecall, which will allow for easy code extensions, such as contracts to perform specific operations in AdEx or complicated defi operations (e.g. adding liquidity to uniswap with only one token by selling for half of the other)

Ivshti commented 3 years ago

This would be convenient but it's dangerous as it may brick the contract if it overwrites storage slots. Or move tokens. Generally a security nightmare