AmbireTech / adex-validator-stack-rust

The Ambire AdEx Validator Stack implemented in Rust: sentry, validator worker, adapter, adview manager
https://adex.network
GNU Affero General Public License v3.0
11 stars 10 forks source link

impl AIP#31 changes to Payout #323

Closed elpiel closed 3 years ago

elpiel commented 4 years ago

Changes

get_payout() - Progress has been made in #313 however there are still work to be done to ensure it's aligned with JS

TODOs:

https://github.com/AdExNetwork/adex-validator-stack-rust/blob/73683e8f38f12e497e8f8a38632378767f4dfdf9/sentry/src/payout.rs#L52-L76

elpiel commented 3 years ago

@simzzz did you check out all the TODOs for the targeting input? Meaning: To check if all of them should be set or not when the payout needs to calculate the targeting input.

PS: I see that the todos haven't been removed.

elpiel commented 3 years ago

All todos have been checked accordingly to @simzzz , closing this issue. Todo comments will be removed with AIP#61 #377