search

AmbireTech / adex-validator

AdEx validator stack reference implementation: sentry, validator worker
https://www.adex.network
GNU Affero General Public License v3.0
8 stars 11 forks source link

expired channels should not be ticked #117

Closed Ivshti closed 5 years ago

Ivshti commented 5 years ago

expired channels should not emit heartbeat or any validator messages - in other words, should not be ticked at all

the best solution seems to be:

  1. implement a query parameter on /channel/list to return active channels only; IMO it should be by default, but /channel/list?withExpired should return expired ones
  2. that way, the worker will just request /channel/list which won't return expired channels and everything is fine
Ivshti commented 5 years ago

this is actually implemented in https://github.com/AdExNetwork/adex-validator-stack-js/blob/master/routes/channel.js#L74