/analytics: by year requests are returning incorrect time groups

AmbireTech / adex-validator

AdEx validator stack reference implementation: sentry, validator worker

https://www.adex.network

GNU Affero General Public License v3.0

8 stars 11 forks source link

/analytics: by year requests are returning incorrect time groups #310

Closed ivopaunov closed 3 years ago

ivopaunov commented 4 years ago

Analytics for year period are grouped by ROUGH_MONTH span that has issue with matching actual start of months because of leap years. We can use mongo aggregations to get the correct start of the months as time groups.

samparsky commented 4 years ago

This will make the query quite complex

ivopaunov commented 4 years ago

It's already done. I'll make PR soon, just need to test it more with the analytics charts on the platform. https://github.com/AdExNetwork/adex-validator/tree/analytics-time-groups-fix

samparsky commented 4 years ago

How is the testing going? Does that fix the issue now?

ivopaunov commented 4 years ago

It's ready. There are just UI touches left.