search

AmrDeveloper / GQL

Git Query language is a SQL like language to perform queries on .git files with supports of most of SQL features such as grouping, ordering and aggregations functions
https://amrdeveloper.github.io/GQL/
MIT License
3.3k stars 90 forks source link

Incorrect comments in function of un_expected_expression_error #79

Closed craftslab closed 9 months ago

craftslab commented 9 months ago

Describe the bug

Incorrect comments in function of un_expected_expression_error

To Reproduce

// https://github.com/AmrDeveloper/GQL/blob/78ca828f952ae0ab22128eb7af0ced6c3442db93/crates/gitql-parser/src/parser.rs#L2158

// `< =` the user may mean to write `<=`
if previous.kind == TokenKind::Greater && current.kind == TokenKind::Equal {
// https://github.com/AmrDeveloper/GQL/blob/78ca828f952ae0ab22128eb7af0ced6c3442db93/crates/gitql-parser/src/parser.rs#L2166

// `> =` the user may mean to write `>=`
if previous.kind == TokenKind::Less && current.kind == TokenKind::Equal {

Expected behavior

// `> =` the user may mean to write `>=`
if previous.kind == TokenKind::Greater && current.kind == TokenKind::Equal {
// `< =` the user may mean to write `<=`
if previous.kind == TokenKind::Less && current.kind == TokenKind::Equal {

GQL (please complete the following information):

Version 0.14.0

Screenshots

None

craftslab commented 9 months ago

Please check it @AmrDeveloper

AmrDeveloper commented 9 months ago

Hello @craftslab,

Thank you for reporting with clear example and fix